Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.20.4 #131

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Update to 1.20.4 #131

merged 1 commit into from
Feb 2, 2024

Conversation

katietheqt-old
Copy link
Contributor

This PR updates Exordium to be compatible with 1.20.4

Copy link

what-the-diff bot commented Feb 2, 2024

PR Summary

  • Switch Initialization Procedure
    The initialization method has been changed from onInitialize to onInitializeClient in 'ExordiumMod.java'.

  • Entrypoints Update
    The entrypoints for the 'client' and 'modmenu' sections were updated in 'fabric.mod.json'.

  • Language Support Tests
    Added additional tests to verify language support capabilities in 'MixinTests.java'.

  • Improved Mod Management
    Implemented a new method initModloader in 'ExordiumMod.java', which helps organize and manage mods in a better way by extending 'ExordiumModBase'.

  • Improved Data Handling
    Added more method implementations and records in 'BufferManager.java', this change could provide more efficient data handling and operation management.

  • Modify Configuration Writing
    The indentation in the writeConfig method in 'ExordiumModBase.java' was adjusted to increase code readability and maintainability.

  • Scoreboard Data Handling
    The 'getScoreboardData' method in 'ScoreboardHelper.java' has changed to use the more efficient 'listPlayerScores' method instead of the previous 'getPlayerScores' method.

  • Language File Settings
    A new setting has been added in the 'en_us.json' file (the reference file for English language settings), providing additional configuration options for users.

  • Mixin File Update
    In 'exordium.mixins.json', several modifications were made for performance improvements, such as adding a robustness checking mechanism (required flag), specifying compatibility level at JAVA_16, adding new client modules, and setting the default requirement for injectors.

  • Gradle Source and Dependencies Update
    Updated Gradle settings in 'gradle-compose.yml' by changing the source field value and updating the dependency values for subProjects.template: Fabric and subProjects.template: FG-Forge.

Please note that several changes across files were made to remove unnecessary whitespaces and improve code readability, however, these do not impact functionality.

@tr7zw
Copy link
Owner

tr7zw commented Feb 2, 2024

🤯 You are crazy 😅. I'll have to check it out later, since you used a different formatter(or maybe this project didn't have one setup yet), checking all 35 will take me a moment. If it's all fine and working I'll release it later today. Also, contact me on Discord (if you want).

@tr7zw
Copy link
Owner

tr7zw commented Feb 2, 2024

Seems all good. Just realized that the formatted got introduced after the last change to the mod, that's why so much changed. The Forge version is broken as in 1.20.2, so I'll disable that part for the release.

@tr7zw tr7zw changed the base branch from 1.20.2 to 1.20.4 February 2, 2024 16:02
@tr7zw tr7zw merged commit fa65d48 into tr7zw:1.20.4 Feb 2, 2024
@R00tB33rMan
Copy link

Ah yes, I decided to push someone to assist me with this mod's upgrade. Your mod is fantastic and I don't want to see it die :(

@tr7zw
Copy link
Owner

tr7zw commented Feb 2, 2024

It's less die, I was just too unmotivated to sink much time into it, after the Forge version was a fail(hotbar doesn't update), and all the other compatibility issues with other mods. Additionally, in 1.20.5 Mojang reworked the UI logic to be less of a mess(but also requiring another rewrite of the core logic), so I was at a low point with this mod.

@R00tB33rMan
Copy link

It's less die, I was just too unmotivated to sink much time into it, after the Forge version was a fail(hotbar doesn't update), and all the other compatibility issues with other mods. Additionally, in 1.20.5 Mojang reworked the UI logic to be less of a mess(but also requiring another rewrite of the core logic), so I was at a low point with this mod.

That's fully understandable. I'd be happy to pull the same person or another contributor in to assist with this huge shift. I have a lot of people under my belt/available for contact and love using this mod to keep my game running smooth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants